Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Onboarding to 2.3.4 #1111

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Bump Onboarding to 2.3.4 #1111

merged 2 commits into from
Jun 18, 2024

Conversation

officiallygod
Copy link
Contributor

@officiallygod officiallygod commented Jun 5, 2024 •
edited
Loading

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Release Notes

https://github.com/newfold-labs/wp-module-onboarding/releases/tag/2.3.3

@officiallygod officiallygod self-assigned this Jun 5, 2024
@cypress Cypress
Copy link

cypress bot commented Jun 5, 2024 •
edited
Loading

6 failed and 1 flaky tests on run #8684 ↗︎

6 376 58 2 Flakiness 1

Details:

Bump Onboarding to 2.3.4
Project: Bluehost Brand Plugin Commit: 031e691dd9
Status: Failed Duration: 34:28 💡
Started: Jun 14, 2024 1:29 PM Ended: Jun 14, 2024 2:04 PM
Failed  Site-Capabilities/siteCapabilities.cy.js • 5 failed tests

View Output Video

Test Artifacts
Verify Wondercart accessibility as per site capabilities > Verify if Sales and Discounts sub tab is displayed Test Replay Screenshots Video
Verify Wondercart accessibility as per site capabilities > Verify Buy Now is shown when canAccessGlobalCTB is true and commerce addon is false Test Replay Screenshots Video
Verify Wondercart accessibility as per site capabilities > Verify clicking on Buy Now leads to cpanel login page Test Replay Screenshots Video
Verify Wondercart accessibility as per site capabilities > Verify Install Now is shown when customer has ecommerce addon Test Replay Screenshots Video
Verify Wondercart accessibility as per site capabilities > Verify clicking Install Now successfully installs Wonder Cart plugin Test Replay Screenshots Video
Failed  Store/storePage.cy.js • 1 failed test

View Output Video

Test Artifacts
Store Page- WooCommerce is deactivated/uninstalled > Verify that Payments tab is not displayed Test Replay Screenshots Video
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test

View Output Video

Test Artifacts
Commerce Home Page- Next Steps > Verify Next steps when experience level is novice Test Replay Screenshots Video

Review all test suite changes for PR #1111 ↗︎

@cypress Cypress
Copy link

cypress bot commented Jun 5, 2024 •
edited
Loading

2 failed and 1 flaky tests on run #8735 ↗︎

2 380 58 2 Flakiness 1

Details:

Merge 031e691 into 94b6fe5...
Project: Bluehost Brand Plugin Commit: d64ccfd7e7 ℹ️
Status: Failed Duration: 26:09 💡
Started: Jun 18, 2024 7:36 PM Ended: Jun 18, 2024 8:02 PM
Failed  Site-Capabilities/siteCapabilities.cy.js • 1 failed test

View Output Video

Test Artifacts
Verify Wondercart accessibility as per site capabilities > Verify clicking Install Now successfully installs Wonder Cart plugin Test Replay Screenshots Video
Failed  Store/storePage.cy.js • 1 failed test

View Output Video

Test Artifacts
Store Page- WooCommerce is deactivated/uninstalled > Verify that Payments tab is not displayed Test Replay Screenshots Video
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test

View Output Video

Test Artifacts
Commerce Home Page- Next Steps > Verify Next steps when experience level is novice Test Replay Screenshots Video

Review all test suite changes for PR #1111 ↗︎

Base automatically changed from release/3.11.0 to main June 5, 2024 19:54
@officiallygod
Copy link
Contributor Author

@circlecube This is the latest release of onboarding that is supposed to go with the plugin, Please take a look whenever you get time, Thanks.

The Failing tests are due to ecom module, Please let me know if there are any other concerns.

@officiallygod officiallygod changed the title Bump Onboarding to 2.3.3 Bump Onboarding to 2.3.4 Jun 14, 2024
@wpalani wpalani changed the base branch from main to develop June 18, 2024 19:33
@wpalani wpalani merged commit 6e8d8bb into develop Jun 18, 2024
9 of 42 checks passed
@wpalani wpalani deleted the update/onboarding branch June 18, 2024 20:11
@wpalani wpalani mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@circlecube circlecube circlecube approved these changes

Assignees

@officiallygod officiallygod

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@officiallygod @circlecube @wpalani